Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update republish time and lightly reorganize republish info #48

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Update republish time and lightly reorganize republish info #48

merged 3 commits into from
Aug 20, 2018

Conversation

neverett
Copy link
Contributor

In this PR:

  • Update to correct package republish time (24 hours)
  • Light reorganization of republish info for clarity

@neverett neverett requested a review from a team as a code owner August 14, 2018 20:57
ljharb
ljharb reviewed Aug 15, 2018
View reviewed changes
doc/cli/npm-unpublish.md Outdated
package again, a new version number must be used.
version combination can never be reused. In order to publish the
package again, a new version number must be used. Additionally,
new versions of unpublished packages may not be republished until 24 hours
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t seem accurate; new versions can be published immediately, altho the old version can never be republished.

Is this a new requirement?

Copy link
Contributor

@iarna iarna Aug 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely unpublished packages have a 24 hour delay before they can be published again. This isn't particularly new, but it's not widely known, thus these docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh ok so it’s only if there remains no published versions, then there’s a 24 hour delay?

Maybe the wording here could be like “fully unpublished” or “new versions of packages with every version unpublished”, so it’s clearer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that rewording, tbh.

@neverett
Copy link
Contributor Author

Thanks @ljharb! Updated with your wording.

ljharb
ljharb approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer to me, thanks <3

zkat
zkat approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🐑 🚀 💥

The only thing that'd be nice is if you wrapped the modified lines to the same length as their surrounding lines, but that's not a big deal if you don't get around to it.

Thank you!

@zkat zkat removed the in-progress label Aug 20, 2018
@zkat zkat changed the base branch from latest to release-next August 20, 2018 22:32
@zkat zkat merged commit 8ed3546 into release-next Aug 20, 2018
@zkat zkat deleted the ne-unpublish branch August 20, 2018 22:33
zkat pushed a commit that referenced this pull request Aug 20, 2018
@neverett @zkat
docs: Update republish time and lightly reorganize republish info (#48)
95031b9 
PR-URL: #48
Credit: @neverett
Reviewed-By: @zkat
isaacs added a commit that referenced this pull request Aug 5, 2019
@isaacs
[email protected]
4050b91 
FEATURES

* [bbcf7b2](npm/hosted-git-info@bbcf7b2)
  [#46](npm/hosted-git-info#46)
  [#43](npm/hosted-git-info#43)
  [#47](npm/hosted-git-info#47)
  [#44](npm/hosted-git-info#44) Add support for
  GitLab groups and subgroups ([@mterrel](https://github.com/mterrel),
  [@isaacs](https://github.com/isaacs),
  [@ybiquitous](https://github.com/ybiquitous))

BUGFIXES

* ([3b1d629](npm/hosted-git-info@3b1d629))
  [#48](npm/hosted-git-info#48) fix http protocol
  using sshurl by default ([@fengmk2](https://github.com/fengmk2))
* [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore
  noCommittish on tarball url generation
  ([@isaacs](https://github.com/isaacs))
* [1692435](npm/hosted-git-info@1692435) use gist
  tarball url that works for anonymous gists
  ([@isaacs](https://github.com/isaacs))
* [d5cf830](npm/hosted-git-info@d5cf830)
* Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
* [e518222](npm/hosted-git-info@e518222)
  Use LRU cache to prevent unbounded memory consumption
  ([@iarna](https://github.com/iarna))
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 8, 2022
Open
@hojatA1 hojatA1 mentioned this pull request Jun 23, 2023
Open
@EMWickd EMWickd mentioned this pull request Jun 24, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Oct 20, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@MrBrain295 MrBrain295 mentioned this pull request Dec 19, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Jan 6, 2024
Open
@Kingcrypto38 Kingcrypto38 mentioned this pull request Jan 11, 2024
Open
antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
@wraithgar
fix: linting (npm#48)
163f021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iarna iarna iarna left review comments

@ljharb ljharb ljharb approved these changes

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neverett @zkat @ljharb @iarna